Skip to content

Add support update request for Stripe gateway #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 18, 2013

Conversation

pilot
Copy link
Contributor

@pilot pilot commented Apr 16, 2013

Tests: pass
BC break: no
Examples: add

@amacneil
Copy link
Contributor

Nice work! I'm just wondering whether update() is the best name for this method, as it's not immediately clear what it does. Perhaps we should rename all the token billing methods to give them a more consistent naming convention?

  • createCard()
  • deleteCard()
  • updateCard()

Thoughts?

@pilot
Copy link
Contributor Author

pilot commented Apr 17, 2013

+1 totally agree, mentioned names is much more clear and correspond with gateways api

@pilot
Copy link
Contributor Author

pilot commented Apr 18, 2013

@adrianmacneil do you have a plan when mege this PR?

@amacneil
Copy link
Contributor

As soon as I get some time to rename those card methods (unless you want to add it to the PR 👍). I was wondering whether anyone else would chip in here with any other suggestions to name the methods.

Also I'll need to release it as version 0.9 since we're changing the API.

@pilot
Copy link
Contributor Author

pilot commented Apr 18, 2013

What about to merge current and tag it with 8.4.5, due I'll prepare PR with total renaming for tag 0.9.0?

I've else have a near plan for a next week to add same save/update feature for the Authorize.Net gateway

@amacneil
Copy link
Contributor

Ok I'll merge it into master now. Do you need a tag? Probably best that people don't start developing with this yet since it's going to be deprecated very soon.

amacneil added a commit that referenced this pull request Apr 18, 2013
Add support update request for Stripe gateway
@amacneil amacneil merged commit d28afd0 into thephpleague:master Apr 18, 2013
@pilot
Copy link
Contributor Author

pilot commented Apr 18, 2013

agree, I'll use a master before 0.9.0 is released

barryvdh pushed a commit that referenced this pull request Feb 13, 2016
Add support update request for Stripe gateway
barryvdh pushed a commit that referenced this pull request Feb 13, 2016
#261 clarify meaning of transactionRef and add transactionId as a sta…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants