-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[BUGFIX] Fix weird alignment for additional contents #4445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @wei-tg, thanks for your PR! I was wondering how did you find this? It's awesome! Did you manage to reproduce this alignment problem? |
Hi @rhymes, I did a DOM comparison between a working page and a page with problems mentioned in the issue. This helped narrow down to where it broke, which was in |
@wei-tg can you please sign the CLA? thanks! |
done so :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I think the problem was when I traced where this code first originated to 76afb43 |
@wei-tg great investigative skills! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with Firefox 70 and Chrome 77, works great!
Thanks again for the PR @wei-tg :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @wei-tg !! LGTM!
What type of PR is this? (check all applicable)
Description
Fixes alignment issue for divs appearing outside
home
containerRelated Tickets & Documents
#4379
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?