Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an internal user interface guide #5721

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Add an internal user interface guide #5721

merged 1 commit into from
Feb 6, 2020

Conversation

jacobherrington
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Adds some docs for the internal UI. Mentions Stimulus and Bootstrap. :)

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

giphy

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 24, 2020
@nickytonline
Copy link
Contributor

I’ll take a peek at this on Monday.

nickytonline
nickytonline suggested changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor changes. Happy to discuss.

docs/internal/internal-user-interface.md Outdated Show resolved Hide resolved
docs/internal/internal-user-interface.md Outdated Show resolved Hide resolved
@pr-triage pr-triage bot added PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes PR: unreviewed bot applied label for PR's with no review and removed PR: unreviewed bot applied label for PR's with no review PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes labels Jan 27, 2020
@jacobherrington jacobherrington force-pushed the jacobherrington/docs/add-internal-user-interface-guide branch from d2e2daa to 20e50af Compare January 27, 2020 21:58
@jacobherrington
Copy link
Contributor Author

@rhymes @nickytonline Changes made! 😄

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 27, 2020
@nickytonline
Copy link
Contributor

LGTM 🚢

citizen428
citizen428 approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@citizen428 citizen428 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @jacobherrington

rhymes
rhymes approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @jacobherrington!

@weekly-digest weekly-digest bot mentioned this pull request Feb 3, 2020
Closed
@mstruve mstruve merged commit 31a1ccc into forem:master Feb 6, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Feb 6, 2020
@weekly-digest weekly-digest bot mentioned this pull request Feb 10, 2020
Closed
@jacobherrington jacobherrington deleted the jacobherrington/docs/add-internal-user-interface-guide branch October 24, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickytonline nickytonline nickytonline approved these changes

@rhymes rhymes rhymes approved these changes

@citizen428 citizen428 citizen428 approved these changes

Assignees

@nickytonline nickytonline

Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jacobherrington @nickytonline @citizen428 @rhymes @mstruve