Better alignment of "Select" and "Remove" buttons with Repo Titles in "Integrations" #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zhao-Andy
reviewed
Oct 5, 2018
| padding: 7px 9px; | ||
| margin-top: 10px; | ||
| width: 100px; | ||
| /*padding: 7px 9px;*/ |
There was a problem hiding this comment.
Let's remove commented-out CSS :)
There was a problem hiding this comment.
Oops! Will take care of it right away lol
benhalpern
reviewed
Oct 5, 2018
There was a problem hiding this comment.
Looks great. I agree with @Zhao-Andy, let's remove the css comments and I think this is good to go
benhalpern
approved these changes
Oct 5, 2018
isogram
pushed a commit
to isogram/dev.to
that referenced
this pull request
Oct 15, 2018
… "Integrations" (forem#836) * Syncing with Upstream master * Dev Env Keys - Algolia and Github * Pull from upstream master * Remove commented code
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Modifies CSS to better align the
SelectandRemovebuttons with the repo titles.Related Tickets & Documents
The issue #745 motivated this Pull Request.
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Screenshot of "Before"
Screenshot of "After"
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?