AWS KMS Support #64
AWS KMS Support #64
Conversation
|
We're building your pull request over on Zeet. |
|
We're building your pull request over on Zeet. |
core/sdk/sdk.ts
Outdated
|
|
||
| // TODO: PLAT-982 | ||
| // Currently we require WALLET_PRIVATE_KEY to be set in order to instantiate the SDK | ||
| // But we need to implement wallet.generate() and wallet.save() to save the private key to file system | ||
|
|
||
| // Need to make this instantiate SDK with read/write. For that will need wallet information | ||
| const sdk = await ThirdwebSDK.fromWallet(wallet, chainName, { | ||
| const sdk = await ThirdwebSDK.fromWallet(wallet!, chainName, { |
There was a problem hiding this comment.
we should throw if wallet is not initialized here, in general avoid using !
There was a problem hiding this comment.
I have this function in startup/index.ts -> walletEnvVariablesCheck() which checks for all the wallet env variables and throws an error if its missing & shuts down the server. But yeah, I can add a throw here too.
|
Updated Readme too. |
| for (let key in obj) { | ||
| for (let str of obj[key]) { | ||
| server.log.info( | ||
| `\t Checking for ${key.toLowerCase()} -> ${str} in env`, |
There was a problem hiding this comment.
probably don't want to log the private key here
There was a problem hiding this comment.
This is just logging the ENV variables and not the value of it.
|
|
||
| export const walletEnvVariablesCheck = async ( | ||
| server: FastifyInstance, | ||
| variables: { [key: string]: string[] }[], |
There was a problem hiding this comment.
do we actually need this? feels much simpler to just do the checks in getSDK no?
There was a problem hiding this comment.
My goal was to not allow the server to start if the ENV variables required are missing. Otherwise, if I added it inside getSDK then the error will only be thrown when and if user pings an end-point.
Added AWS KMS Support using ENV Variables. The implementation checks for
awsKmsWallet ENV Variables andwalletPPK. If neither present prints an Error and stops server.