-
Notifications
You must be signed in to change notification settings - Fork 100
AWS KMS Support #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
AWS KMS Support #64
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
391b12b
Added AWS KMS Wallet
farhanW3 b376b71
Added Different Wallet Setup Checks
farhanW3 6f70494
added missing package
farhanW3 35bfe3b
updated with feedback & Readme
farhanW3 7e4f29b
spelling mistake update
farhanW3 fc3f783
Merge branch 'main' into farhan/plat-1047
farhanW3 ddf92a5
updated readme. startup script & constants
farhanW3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,13 +5,43 @@ export const envVariablesCheck = async ( | |
server: FastifyInstance, | ||
variables: string[], | ||
) => { | ||
server.log.info(`Checking for required env variables`); | ||
|
||
server.log.info(`Checking for Required env variables`); | ||
for (let str of variables) { | ||
server.log.info(`Checking for ${str} in env`); | ||
server.log.info(`\t Checking for ${str} in env`); | ||
if (!getEnv(str, undefined)) { | ||
server.log.error(`${str} not found in env`); | ||
process.exit(1); | ||
} | ||
} | ||
}; | ||
|
||
export const walletEnvVariablesCheck = async ( | ||
server: FastifyInstance, | ||
variables: { [key: string]: string[] }[], | ||
) => { | ||
let resultArr: boolean[] = []; | ||
let keyResult: boolean; | ||
server.log.info(`Checking for Wallet Setup ENV variables`); | ||
for (let obj of variables) { | ||
keyResult = true; | ||
for (let key in obj) { | ||
for (let str of obj[key]) { | ||
server.log.info( | ||
`\t Checking for ${key.toLowerCase()} -> ${str} in env`, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. probably don't want to log the private key here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is just logging the ENV variables and not the value of it. |
||
); | ||
keyResult = keyResult && !!getEnv(str, undefined); | ||
} | ||
resultArr.push(keyResult); | ||
} | ||
if (resultArr.includes(true)) { | ||
break; | ||
} | ||
} | ||
|
||
if (!resultArr.includes(true)) { | ||
server.log.error( | ||
`Please set WALLET_PRIVATE_KEY or [AWS_REGION, AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, AWS_KMS_KEY_ID] for AWS KMS Wallet on .env file`, | ||
); | ||
process.exit(1); | ||
} | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we actually need this? feels much simpler to just do the checks in getSDK no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My goal was to not allow the server to start if the ENV variables required are missing. Otherwise, if I added it inside
getSDK
then the error will only be thrown when and if user pings an end-point.