Skip to content

Commit 9442dc7

Browse files
[SDK] Rename otherWallets to allConnectedWallets in onConnect callback (#8407)
<!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the `onConnect` callback in the `AutoConnect` component to improve clarity in variable naming, changing `otherWallets` to `allConnectedWallets`. ### Detailed summary - Changed the parameter name in `onConnect` from `otherWallets` to `allConnectedWallets`. - Updated the console log statement to reflect the new parameter name, changing it from "other wallets that were also connected" to "all connected wallets". > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Breaking Changes** * Updated parameter naming in the AutoConnect callback configuration to align with updated documentation. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent 6c4e684 commit 9442dc7

File tree

1 file changed

+3
-3
lines changed
  • packages/thirdweb/src/wallets/connection

1 file changed

+3
-3
lines changed

packages/thirdweb/src/wallets/connection/types.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,14 +101,14 @@ export type AutoConnectProps = {
101101
*
102102
* ```tsx
103103
* <AutoConnect
104-
* onConnect={(activeWallet, otherWallets) => {
104+
* onConnect={(activeWallet, allConnectedWallets) => {
105105
* console.log("auto connected to", activeWallet)
106-
* console.log("other wallets that were also connected", otherWallets)
106+
* console.log("all connected wallets", allConnectedWallets)
107107
* }}
108108
* />
109109
* ```
110110
*/
111-
onConnect?: (activeWallet: Wallet, otherWallets: Wallet[]) => void;
111+
onConnect?: (activeWallet: Wallet, allConnectedWallets: Wallet[]) => void;
112112

113113
/**
114114
* Optional chain to autoconnect to

0 commit comments

Comments
 (0)