Skip to content

Conversation

kien-ngo
Copy link
Contributor

Problem solved

This is a subset of the changes from the draft PR below. Since #1648 contains too many changes I will split it up into smaller PRs

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: explain the internal logic changes

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2023

🦋 Changeset detected

Latest commit: 7d89858

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@thirdweb-dev/sdk Patch
thirdweb Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
packages/sdk/src/evm/core/classes/erc-721.ts 74.25% <88.88%> (-0.25%) ⬇️

📢 Thoughts on this report? Let us know!.

@kien-ngo kien-ngo marked this pull request as ready for review September 28, 2023 04:33
@kien-ngo kien-ngo requested review from a team, jnsdls and joaquim-verges September 28, 2023 04:33
Copy link
Member

@joaquim-verges joaquim-verges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are great, one thing i recommend is just to add a console.time() for some of these to see the before/after, just while you dev to see the delta. wonder how much we're saving here!

@joaquim-verges joaquim-verges added this pull request to the merge queue Sep 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 28, 2023
@joaquim-verges joaquim-verges added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit 6897ad6 Sep 28, 2023
@joaquim-verges joaquim-verges deleted the kien/update branch September 28, 2023 16:54
@github-actions github-actions bot mentioned this pull request Sep 28, 2023
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
Add files via upload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants