Skip to content

[SDK] Performance improvement to various function for ERC721 #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 28, 2023
Merged

[SDK] Performance improvement to various function for ERC721 #1678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9875c9e
Code
kien-ngo Sep 27, 2023
dba7491
Add changeset
kien-ngo Sep 28, 2023
1923df5
Merge branch 'main' into kien/update
kien-ngo Sep 28, 2023
ab934f1
Fix
kien-ngo Sep 28, 2023
7d89858
Update
kien-ngo Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/large-beans-march.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@thirdweb-dev/sdk": patch
---

Performance improvement to various function for ERC721
32 changes: 20 additions & 12 deletions packages/sdk/src/evm/core/classes/erc-721.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,10 +279,14 @@ export class Erc721<
*/
transferFrom = /* @__PURE__ */ buildTransactionFunction(
async (from: AddressOrEns, to: AddressOrEns, tokenId: BigNumberish) => {
const [fromAddress, toAddress] = await Promise.all([
resolveAddress(from),
resolveAddress(to),
]);
return Transaction.fromContractWrapper({
contractWrapper: this.contractWrapper,
method: "transferFrom(address,address,uint256)",
args: [await resolveAddress(from), await resolveAddress(to), tokenId],
args: [fromAddress, toAddress, tokenId],
});
},
);
Expand Down Expand Up @@ -422,13 +426,14 @@ export class Erc721<
if (this.query?.owned) {
return this.query.owned.all(walletAddress);
} else {
const address =
walletAddress || (await this.contractWrapper.getSignerAddress());
const allOwners = await this.getAllOwners();
return Promise.all(
const [address, allOwners] = await Promise.all([
walletAddress || this.contractWrapper.getSignerAddress(),
this.getAllOwners(),
]);
return await Promise.all(
(allOwners || [])
.filter((i) => address?.toLowerCase() === i.owner?.toLowerCase())
.map(async (i) => await this.get(i.tokenId)),
.map((i) => this.get(i.tokenId)),
);
}
}
Expand All @@ -445,9 +450,10 @@ export class Erc721<
if (this.query?.owned) {
return this.query.owned.tokenIds(walletAddress);
} else {
const address =
walletAddress || (await this.contractWrapper.getSignerAddress());
const allOwners = await this.getAllOwners();
const [address, allOwners] = await Promise.all([
walletAddress || this.contractWrapper.getSignerAddress(),
this.getAllOwners(),
]);
return (allOwners || [])
.filter((i) => address?.toLowerCase() === i.owner?.toLowerCase())
.map((i) => BigNumber.from(i.tokenId));
Expand Down Expand Up @@ -902,9 +908,11 @@ export class Erc721<
* @twfeature ERC721ClaimCustom | ERC721ClaimPhasesV2 | ERC721ClaimPhasesV1 | ERC721ClaimConditionsV2 | ERC721ClaimConditionsV1
*/
public async totalUnclaimedSupply(): Promise<BigNumber> {
return (await this.nextTokenIdToMint()).sub(
await this.totalClaimedSupply(),
);
const [nextTokenIdToMint, totalClaimedSupply] = await Promise.all([
this.nextTokenIdToMint(),
this.totalClaimedSupply(),
]);
return nextTokenIdToMint.sub(totalClaimedSupply);
}

/**
Expand Down