-
Notifications
You must be signed in to change notification settings - Fork 586
[SDK] generateWallet utility function #2602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] generateWallet utility function #2602
Conversation
🦋 Changeset detectedLatest commit: 2eaf04a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @gregfromstl ! Just a naming thing and let's get this in
Also can you add a changeset?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice, 1 bit of feedback and also if you could add a changeset using pnpm changeset
at the root (then follow the prompts)
this should be a minor
version as we're adding new public api surface area, please write a couple of sentences what was added (obvious in this case, doesn't have to be a novel) - it will end up in the public changelog.md file and in the github release tag
wow simultaneous reviews |
tbh the codex PR content would make a decent changeset... maybe there's something to be said about AI generated changesets... |
and let me fix the test issues for forks finally :) - will do separately and then merge back to this PR |
Thank you both! Renamed the function and added that changeset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just the docstrings left, and then I'll update once #2604 is in main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lets see if I fixed all the tests |
evidently not |
Bumps [swagger-ui-react](https://github.com/swagger-api/swagger-ui) from 5.17.2 to 5.17.14. - [Release notes](https://github.com/swagger-api/swagger-ui/releases) - [Changelog](https://github.com/swagger-api/swagger-ui/blob/master/.releaserc) - [Commits](swagger-api/swagger-ui@v5.17.2...v5.17.14) --- updated-dependencies: - dependency-name: swagger-ui-react dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Problem solved
Simple function to generate a new wallet via a random private key.
Changes made
thirdweb/wallets
How to test
All logic is covered by existing tests.
PR-Codex overview
This PR adds a
generateAccount
function tothirdweb
for creating random local accounts.Detailed summary
generateAccount
function to create a random account with a private keywallets.ts
to includegenerateAccount