Skip to content

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Mar 30, 2024

Problem solved

Simple function to generate a new wallet via a random private key.

Changes made

  • Public API changes: new function exposed on thirdweb/wallets

How to test

All logic is covered by existing tests.


PR-Codex overview

This PR adds a generateAccount function to thirdweb for creating random local accounts.

Detailed summary

  • Added generateAccount function to create a random account with a private key
  • Updated exports in wallets.ts to include generateAccount
  • Updated dependencies and removed unnecessary configurations

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested a review from a team March 30, 2024 19:25
Copy link

changeset-bot bot commented Mar 30, 2024

🦋 Changeset detected

Latest commit: 2eaf04a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@joaquim-verges joaquim-verges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gregfromstl ! Just a naming thing and let's get this in

@joaquim-verges
Copy link
Member

Also can you add a changeset?

pnpm changeset from the root of the repo

Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, 1 bit of feedback and also if you could add a changeset using pnpm changeset at the root (then follow the prompts)

this should be a minor version as we're adding new public api surface area, please write a couple of sentences what was added (obvious in this case, doesn't have to be a novel) - it will end up in the public changelog.md file and in the github release tag

@jnsdls
Copy link
Member

jnsdls commented Mar 30, 2024

wow simultaneous reviews

@jnsdls
Copy link
Member

jnsdls commented Mar 30, 2024

tbh the codex PR content would make a decent changeset...

maybe there's something to be said about AI generated changesets...

@jnsdls
Copy link
Member

jnsdls commented Mar 30, 2024

and let me fix the test issues for forks finally :) - will do separately and then merge back to this PR

@gregfromstl
Copy link
Member Author

Thank you both! Renamed the function and added that changeset

Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the docstrings left, and then I'll update once #2604 is in main

Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnsdls
Copy link
Member

jnsdls commented Mar 31, 2024

lets see if I fixed all the tests

@jnsdls
Copy link
Member

jnsdls commented Mar 31, 2024

evidently not

@jnsdls jnsdls merged commit 3aaad1e into thirdweb-dev:main Apr 1, 2024
@jnsdls jnsdls mentioned this pull request Apr 1, 2024
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
Bumps [swagger-ui-react](https://github.com/swagger-api/swagger-ui) from 5.17.2 to 5.17.14.
- [Release notes](https://github.com/swagger-api/swagger-ui/releases)
- [Changelog](https://github.com/swagger-api/swagger-ui/blob/master/.releaserc)
- [Commits](swagger-api/swagger-ui@v5.17.2...v5.17.14)

---
updated-dependencies:
- dependency-name: swagger-ui-react
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants