Skip to content

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Mar 30, 2024

PR-Codex overview

This PR adds TW_SECRET_KEY to globalEnv, updates test suites to run without TW_SECRET_KEY, and refactors code to handle secret key absence during testing.

Detailed summary

  • Added TW_SECRET_KEY to globalEnv
  • Updated test suites to run without TW_SECRET_KEY
  • Refactored code to handle secret key absence during testing

The following files were skipped due to too many changes: packages/thirdweb/src/extensions/prebuilts/deploy-erc1155.test.ts, packages/thirdweb/src/extensions/prebuilts/deploy-erc721.test.ts, legacy_packages/storage/test/ipfs.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@jnsdls jnsdls requested a review from joaquim-verges as a code owner March 30, 2024 23:27
@jnsdls jnsdls requested a review from a team March 30, 2024 23:27
Copy link

changeset-bot bot commented Mar 30, 2024

⚠️ No Changeset found

Latest commit: 551c38f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jnsdls jnsdls changed the title Jd/fix tests without secret key chore(tests): skip tests that will fail without secret key set Mar 30, 2024
Copy link

codspeed-hq bot commented Mar 30, 2024

CodSpeed Performance Report

Merging #2604 will not alter performance

Comparing jd/fix-tests-without-secret-key (551c38f) with main (82e5f53)

Summary

✅ 9 untouched benchmarks

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.15%. Comparing base (82e5f53) to head (551c38f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2604       +/-   ##
===========================================
- Coverage   65.84%   18.15%   -47.70%     
===========================================
  Files         293     1952     +1659     
  Lines       10875   111977   +101102     
  Branches     1570     2274      +704     
===========================================
+ Hits         7161    20324    +13163     
- Misses       3079    91000    +87921     
- Partials      635      653       +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jnsdls jnsdls merged commit b6a6eae into main Mar 30, 2024
@jnsdls jnsdls deleted the jd/fix-tests-without-secret-key branch March 30, 2024 23:58
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
fix: fallback to address on failed ens resolution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant