This repository was archived by the owner on Aug 30, 2022. It is now read-only.
Implement Signature Drop SDK wrapper #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeto
force-pushed
the
ndeto/implement-signature-drop-sdk-wrapper
branch
3 times, most recently
from
54c2ea3 to
fff823d
Compare
|
This pull request introduces 2 alerts when merging f87202b into 79d199d - view on LGTM.com new alerts:
|
ndeto
force-pushed
the
ndeto/implement-signature-drop-sdk-wrapper
branch
2 times, most recently
from
b530a90 to
4cd2ba6
Compare
|
This pull request introduces 1 alert when merging e8e3188 into 7a9a2e0 - view on LGTM.com new alerts:
|
ndeto
force-pushed
the
ndeto/implement-signature-drop-sdk-wrapper
branch
2 times, most recently
from
2261cf1 to
ce883e7
Compare
ndeto
changed the title
ndeto
force-pushed
the
ndeto/implement-signature-drop-sdk-wrapper
branch
from
4ea1758 to
8ecb002
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear Ticket
This PR implements the SignatureDrop SDK wrapper
Context:
I've named it
MyNFTDropbecause of the conflicts I was getting while usingNFTDrop. I'd appreciate suggestions.The documentation is not accurate as well. To be corrected
As for the tests, I'm running the
yash/sign-drop-testbranch for the smart contracts since there's a different implementation with the permissions.I'd love comments on any of the above, as well as feedback on the general things i might have missed while creating the MyNFTClass.