Remove methods causing issues during initialization and creation of schema when database has different name than postgres

[pacospace]

Related Issues and Dependencies

Due to issue in sqlalchmey_utils which use default postgres database name: kvesteri/sqlalchemy-utils#372

Fixes: thoth-station/thoth-application#41

This introduces a breaking change

• Yes
• No

This should yield a new module release

• Yes
• No

This Pull Request implements

Adapt methods that were causing issue when the name of the database is not postgres from sqlalchemy utils.

[todo]

Remove once kvesteri/sqlalchemy-utils#372 is merged and new release of sqlalchemy_utils is released

storages/thoth/storages/graph/postgres.py

Lines 269 to 274 in 3beaa1d

	#TODO: Remove once https://github.com/kvesteri/sqlalchemy-utils/pull/372 is merged and new release of sqlalchemy_utils is released
	is_successfully_started = False
	try:
	self._engine = create_engine(self.construct_connection_string(), echo=echo)
	self._sessionmaker = sessionmaker(bind=self._engine)
	self._is_successfully_started = True

---

This comment was generated by todo based on a TODO comment in 3beaa1d in #1842. cc @pacospace.

[fridex]

Is there a need for a new object attribute? If so it should go to the __init__ if we want to use it in other methods. Otherwise it can be a variable.

[pacospace]

Removed and implemented methods in postgres_utils.py :)

[ghost]

Build failed.

• thoth-coala : FAILURE in 58s
• thoth-pytest : FAILURE in 5m 42s

[todo]

Remove once kvesteri/sqlalchemy-utils#372 is merged and new release of sqlalchemy_utils is issued

storages/thoth/storages/graph/postgres.py

Lines 269 to 274 in 0e8223f

	#TODO: Remove once https://github.com/kvesteri/sqlalchemy-utils/pull/372 is merged and new release of sqlalchemy_utils is issued
	is_successfully_started = False
	try:
	self._engine = create_engine(self.construct_connection_string(), echo=echo)
	self._sessionmaker = sessionmaker(bind=self._engine)
	is_successfully_started = True

---

This comment was generated by todo based on a TODO comment in 0e8223f in #1842. cc @pacospace.

[ghost]

Build failed.

• thoth-coala : RETRY_LIMIT in 59s
• thoth-pytest : FAILURE in 2m 21s

[todo]

remove once kvesteri/sqlalchemy-utils#372 is merged

storages/thoth/storages/graph/postgres_utils.py

Lines 3 to 8 in c5dae67

	# TODO: remove once https://github.com/kvesteri/sqlalchemy-utils/pull/372 is merged
	#
	###################################################################
	# SQLAlchemy utils methods
	# Copyright (c) 2012, Konsta Vesterinen
	#

---

This comment was generated by todo based on a TODO comment in c5dae67 in #1842. cc @pacospace.

[ghost]

Build failed.

• thoth-coala : FAILURE in 56s
• thoth-pytest : FAILURE in 5m 41s

[fridex]

let's have it in 👍

thanks! 👏

[fridex]

recheck

[ghost]

Build failed.

• thoth-coala : FAILURE in 54s
• thoth-pytest : FAILURE in 5m 38s

[ghost]

Build failed.

• thoth-coala : FAILURE in 52s
• thoth-pytest : SUCCESS in 4m 55s

[ghost]

Build failed.

• thoth-pytest : FAILURE in 5m 37s

[fridex]

recheck

[ghost]

Build failed.

• thoth-pytest : FAILURE in 5m 44s

[ghost]

Build failed.

• thoth-pytest : FAILURE in 5m 41s

[ghost]

Build failed.

• thoth-pytest : FAILURE in 5m 40s

[ghost]

Build failed.

• thoth-pytest : FAILURE in 3m 23s

[ghost]

Build failed.

• thoth-pytest : FAILURE in 5m 35s

[fridex]

recheck

[ghost]

Build succeeded.

• thoth-pytest : SUCCESS in 5m 50s

[ghost]

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

• thoth-pytest : FAILURE in 5m 39s

[fridex]

I'll merge this manually to ship new release.