Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoth natively supports a differential analysis #257

Closed
TomasTomecek opened this issue Jul 19, 2022 · 6 comments
Closed

Thoth natively supports a differential analysis #257

TomasTomecek opened this issue Jul 19, 2022 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@TomasTomecek
Copy link

Is your feature request related to a problem? Please describe.

As a Thoth user, I'd love to compare an advise of a PR with an advise done on the main branch easily with a single thamos advise command.

High-level Goals

Running advise produces results that only contain difference from a different advise.
These are available both via Web UI and on CLI.

Describe the solution you'd like
That's up to you :)

Additional context
There already is a compare button in the Web UI. Sadly the past advises are not tagged in any way so it's hard to tell what to compare against.

Acceptance Criteria

  • Running thamos advise produces results with difference from another analysis.
@TomasTomecek TomasTomecek added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 19, 2022
@sesheta
Copy link
Member

sesheta commented Jul 19, 2022

@TomasTomecek: This issue is currently awaiting triage.
One of the @thoth-station/devs will take care of the issue, and will accept the issue by applying the
triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta added needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. needs-sig labels Jul 19, 2022
@goern
Copy link
Member

goern commented Jul 20, 2022

/sig user-experience
/priority important-soon

@sesheta sesheta added sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-sig labels Jul 20, 2022
@harshad16
Copy link
Member

This is regarding having similar compare support in thamos.
Acceptance criteria

  • Add additional command for compare of different advise analysis
  • Utilize the function of the git diff.
  • Figure the way to store the advise id (small term cache) for comparision.
  • Verify the result w.r.t to the search/compare.

Story Point: [Epic][13pt]

@Gkrumbach07 Gkrumbach07 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. labels Jul 25, 2022
@Gkrumbach07
Copy link
Member

@goern
Copy link
Member

goern commented Aug 11, 2022

/close
as we work on it on

@sesheta
Copy link
Member

sesheta commented Aug 11, 2022

@goern: Closing this issue.

In response to this:

/close
as we work on it on

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta closed this as completed Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: Done
Development

No branches or pull requests

5 participants