Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 400 responses where not needed #250

Merged
1 commit merged into from
Sep 18, 2018
Merged

Remove 400 responses where not needed #250

1 commit merged into from
Sep 18, 2018

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Sep 18, 2018

No description provided.

@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 18, 2018
@fridex fridex requested a review from goern September 18, 2018 08:26
@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 18, 2018
@todo
Copy link

todo bot commented Sep 18, 2018

make sure if Ceph returns objects in the same order each time.

user-api/thoth_user_api/api_v1.py

Lines 226 to 231 in ba6ca1d

return _get_document(BuildLogsStore, document_id)
def parse_log(log_info: dict):
"""Parse image build log or install log."""
parameters = locals()

This comment was generated by todo based on a TODO comment in ba6ca1d in #250. cc @fridex.

@ghost
Copy link

ghost commented Sep 18, 2018

Build succeeded.

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2018
@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 18, 2018
@ghost
Copy link

ghost commented Sep 18, 2018

Build succeeded (gate pipeline).

@ghost ghost merged commit 0a54439 into thoth-station:master Sep 18, 2018
@todo todo bot mentioned this pull request Sep 18, 2018
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goern goern goern approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fridex @goern @sesheta