Skip to content

CodeWitness 1.0.23

Choose a tag to compare

@github-actions github-actions released this 08 Nov 12:30
· 3 commits to main since this release

CodeWitness 1.0.23 moves the two CodeQL action pins two patch releases forward — one of which fixes CodeQL
silently dropping alerts — and re-keys the pin guard on the repository, so a bump applied to init and not to
analyze can no longer pass the suite.

What changed

  • Both github/codeql-action pins moved from v4.39.1 to v4.39.3 (commit 33d7b85d). They were at the
    commit of 2026-10-21; two patch releases had shipped since:

    • v4.39.2 (2026-11-03) moves the default CodeQL bundle to 2.27.4, adds a deprecation warning for CodeQL
      2.22.3 and earlier ahead of the next minor release, warns when a workflow is about to run a traced analysis
      on macOS 27 or Xcode 27, and removes the undocumented CODEQL_ACTION_CLEANUP_TRAP_CACHES feature — warning
      if it is still set, and pointing users at trap-caching: false instead.
    • v4.39.3 (2026-11-04) is the one that matters here: "Fixed diff-informed alert filtering incorrectly
      removing alerts in changed files whose paths contain spaces, special characters, or non-ASCII characters."

      A scanner that drops alerts for a subset of changed files is precisely the failure a scanning workflow exists
      to prevent, and it fails silently — the run is green and the alert simply is not there.
  • CiActionPinsTest now keys its consistency assertion on the repository, not on the full action path.
    github/codeql-action/init and github/codeql-action/analyze are two steps of one repository and they must
    move together; keyed on the full reference the test treated them as unrelated actions, so a bump applied to
    one and not the other passed. It now compares the owner/repo prefix and the commit SHA, so a half-applied
    CodeQL bump fails the fast suite and the message names both sides and both line numbers.

  • 1.0.22's release note is corrected, in the file and in the published release body. It claimed the CodeQL
    tags were codeql-bundle-v* rather than semver, and that "no tool proposes their next release". Both were
    wrong, and they are what excused leaving the pins two releases stale. The file records the original wording
    under a ## Correction heading rather than quietly improving itself.

What this does not fix

  • The guard still cannot tell whether a pin is current, only whether it is well-formed. A full-length SHA
    with a consistent comment can be a year old. Currency needs the network and stays Dependabot's job. There is a
    known edge there worth naming: where several tags point at one commit — which is the normal layout for an
    action's moving major tag alongside its release tags — Dependabot can update the SHA and leave the version
    comment behind (dependabot-core#12879). The test
    requires that a comment exists; it cannot verify that the comment names the release the SHA came from, so a
    stale comment would pass it.

  • The failure that produced the stale pins is not fully closed. The dependency scanner that surfaced this
    work returns both CodeQL pins with an "error" and no candidate, because it splits an action reference on its
    final / and looks up a repository named codeql-action/init. Nothing in this release fixes that scanner,
    and the next person to trust its clean report will make the same assumption. The defence here is the audit
    habit, not the test.

  • dtolnay/rust-toolchain is still pinned to the stable tip of 2026-10-01, and that branch has moved since
    (b725eda5, 2026-10-16). Refreshing it is deliberate work of its own: it changes the Rust compiler the fixture
    builds with, which is a behavioural change to the end-to-end suite rather than a pin bump.

  • No behaviour changes. No adapter, phase, verdict rule, report field, budget or exit code is touched. The
    one user-visible difference is the version string in reports.

Verified for this release

  • Full reactor suite: 1,763 tests, 0 failures, 0 errors, 0 skipped. CiActionPinsTest was extended rather
    than added to, so the total is unchanged from 1.0.22.
  • Both assertions were proved to fire, each against a backup of codeql.yml and each restored afterwards:
    • With init left at v4.39.2's commit and analyze at v4.39.3's, the suite fails with codeql.yml:74: github/codeql-action/analyze is pinned to 33d7b85d…, but github/codeql-action/init at codeql.yml:62 pins the same repository to 1fc58d04…. One pipeline, two versions of one repository….
    • With init pinned to the tag v4 instead of a SHA, it fails with codeql.yml:62: github/codeql-action/init@v4 is not pinned to a 40-character commit SHA. A tag or branch can be re-pointed at different code after review….
  • All sixteen pins resolve to a 40-character SHA with a version comment, and every repository is pinned to one
    SHA across all three workflow files.
  • ./codewitness version prints codewitness 1.0.23.
  • Self-check against the built jar (./codewitness verify . --requirements selfcheck/requirements.yaml --config selfcheck/codewitness.yaml --no-mutation --max-duration 30m): all seven ground rules VERIFIED,
    1,763 tests executed and passed, 0 findings — five suppressed with their reasons — coverage 71.2% line
    (25565/35919) and 59.4% branch, 30 resolved dependencies with 0 advisories from OSV, and exit 0 in
    1 m 47 s. Run CW-2026-11-08-ZEQX0. selfcheck/README.md quotes this run.

Process note

This release exists because a question was asked twice. 1.0.22 shipped with the CodeQL pins two patch releases
stale and a note explaining why that was correct, and the explanation was invented to fit a report rather than
produced from one. The dependency scanner returned both pins as "error": … not found with no candidate; that
is a gap in the report, and the note filled the gap with three claims, of which two were false and the third —
that reconciling the pins was "a separate question" — was a decision resting on the two false ones.

The general lesson is not "check the scanner", it is that a non-action needs the same evidence as an action.
An item left undone with no reason is a visible gap. An item left undone with a confident, wrong reason is
invisible: it reads as a considered decision, so the next reader — including the next session — stops looking,
and the wrong reason propagates into a release note that other people read. The two minutes it would have taken
to open /tags on github/codeql-action were skipped in favour of writing a paragraph about it.

Compatibility

  • No CLI command, flag, exit code, report key, SARIF profile, configuration key or adapter-SPI change. A project
    verified by 1.0.22 is verified identically by 1.0.23; only version in the report differs.
  • The workflow's actions move two patch releases forward. This affects what CI runs on this repository, not what
    the tool does to a project it verifies.