shim: parallel submission #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
pepyakin
force-pushed
the
pep-rollkit-downgrade-goda
branch
from
417ed72 to
f6d7847
Compare
pepyakin
force-pushed
the
pep-shim-parallel-submission
branch
from
3cf1316 to
92879ec
Compare
pepyakin
force-pushed
the
pep-shim-parallel-submission
branch
from
92879ec to
cc076e1
Compare
rollkit demo submits a lot of blobs. In my testing I saw dozens of blobs submitted at the same time. Ofc submitting those serially won't cut it, esp. so if waiting until finalization. This changeset solves the problem by splitting the signing part, which is still serial, and the submission, which is now parallel. As a drive-by fix, all the errors for rollkit are now encapsulated into an enum. Closes #259
gabriele-0201
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Great implementation. It makes it possible to have more freedom in dock implementations. I like the RollkitDockError enum, it makes the code a lot nicer!
The only thing is that I would pay more attention to nonce usage. Users should be more aware of how it is handled, but this is addressed in the follow-up PR
pepyakin
force-pushed
the
pep-shim-parallel-submission
branch
from
cc076e1 to
2f18d88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rollkit demo submits a lot of blobs. In my testing I saw
dozens of blobs submitted at the same time. Ofc submitting
those serially won't cut it, esp. so if waiting until
finalization.
This changeset solves the problem by splitting the signing
part, which is still serial, and the submission, which is
now parallel.
As a drive-by fix, all the errors for rollkit are now
encapsulated into an enum.
Closes #259