cli: add a note about submission key #271
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the version that was introduced in #260 (997046d) was using the latest version of go-da (0.4.0) gRPC service decl. However, the latest version of rollkit on which the gm demo was based off, was using 0.2.0. That was causing occasional problems. So I went ahead and downgraded it. Now, it seems to workfine (with exception of #259). Closes #258.
rollkit demo submits a lot of blobs. In my testing I saw dozens of blobs submitted at the same time. Ofc submitting those serially won't cut it, esp. so if waiting until finalization. This changeset solves the problem by splitting the signing part, which is still serial, and the submission, which is now parallel. As a drive-by fix, all the errors for rollkit are now encapsulated into an enum. Closes #259
nonce handling is assumed to be perfomed only by a single process in the network. Otherwise, there may be two processes that signed an extrinsic with the same nonce. This may lead to rejection of one of the extrinsics.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
pepyakin
force-pushed
the
pep-shim-parallel-submission
branch
from
cc076e1 to
2f18d88
Compare
gabriele-0201
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nonce handling is assumed to be perfomed only by a single process
in the network. Otherwise, there may be two processes that signed
an extrinsic with the same nonce. This may lead to rejection
of one of the extrinsics.