Skip to content

Conversation

Oksamies
Copy link
Contributor

@Oksamies Oksamies commented Oct 6, 2025

No description provided.

Copy link

coderabbitai bot commented Oct 6, 2025

Walkthrough

The README in apps/cyberstorm-remix was updated to replace instructions for editing vite.config.ts with guidance to configure local test domains via the environment variable __VITE_ADDITIONAL_SERVER_ALLOWED_HOSTS (e.g., __VITE_ADDITIONAL_SERVER_ALLOWED_HOSTS=.thunderstore.temp). It notes that localhost remains enabled by default. No exported or public APIs were changed.

Possibly related PRs

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning No pull request description was provided, so there is no contextual information about the changes beyond the title and file diffs. This absence means the description fails to convey any details of the update. Please add a brief description summarizing the README update for using the VITE_ADDITIONAL_SERVER_ALLOWED_HOSTS environment variable instead of editing allowedHosts directly.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title accurately summarizes the primary change by indicating an update to the Nimbus README for setting up allowedHosts, which aligns with the modifications described in the summary. It is concise and focuses on the main change without extraneous details.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 10-06-update_nimbus_readme_with_enw_allowedhosts_setup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor Author

Oksamies commented Oct 6, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Oksamies Oksamies requested a review from anttimaki October 6, 2025 10:49
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/cyberstorm-remix/README.md (1)

39-40: Tighten the wording in step 5.

Change “in to” → “into” for smoother reading.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8a8c170 and 9654c57.

📒 Files selected for processing (1)
  • apps/cyberstorm-remix/README.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Build
  • GitHub Check: Generate visual diffs

Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 10.70%. Comparing base (37e7161) to head (9654c57).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1568   +/-   ##
=======================================
  Coverage   10.70%   10.70%           
=======================================
  Files         285      285           
  Lines       19871    19871           
  Branches      385      385           
=======================================
  Hits         2128     2128           
  Misses      17743    17743           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

```

5. Uncomment the following string to the `allowedHosts` list in `vite.config.ts` ([link](https://github.com/thunderstore-io/thunderstore-ui/blob/f69ca05f2fe51320768aa4b934d17e40060192b5/apps/cyberstorm-remix/vite.config.ts#L13-L17)): `".thunderstore.temp"`
5. Add your local test domains (e.g. `".thunderstore.temp"`) in to env variable `__VITE_ADDITIONAL_SERVER_ALLOWED_HOSTS=`; like this `__VITE_ADDITIONAL_SERVER_ALLOWED_HOSTS=.thunderstore.temp`. (`localhost` is enabled by default)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this just be part of step 4? "Here's a example of file contents for development environment:"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to keep it as a separate step to pronounce the thought process of "what is the local domain I'll be using". I can change it if my thinking sounds weird

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants