-
Notifications
You must be signed in to change notification settings - Fork 5
Update Nimbus README with enw allowedHosts setup #1568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update Nimbus README with enw allowedHosts setup #1568
Conversation
WalkthroughThe README in apps/cyberstorm-remix was updated to replace instructions for editing vite.config.ts with guidance to configure local test domains via the environment variable __VITE_ADDITIONAL_SERVER_ALLOWED_HOSTS (e.g., __VITE_ADDITIONAL_SERVER_ALLOWED_HOSTS=.thunderstore.temp). It notes that localhost remains enabled by default. No exported or public APIs were changed. Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/cyberstorm-remix/README.md (1)
39-40
: Tighten the wording in step 5.Change “in to” → “into” for smoother reading.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/cyberstorm-remix/README.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build
- GitHub Check: Generate visual diffs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1568 +/- ##
=======================================
Coverage 10.70% 10.70%
=======================================
Files 285 285
Lines 19871 19871
Branches 385 385
=======================================
Hits 2128 2128
Misses 17743 17743 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
``` | ||
|
||
5. Uncomment the following string to the `allowedHosts` list in `vite.config.ts` ([link](https://github.com/thunderstore-io/thunderstore-ui/blob/f69ca05f2fe51320768aa4b934d17e40060192b5/apps/cyberstorm-remix/vite.config.ts#L13-L17)): `".thunderstore.temp"` | ||
5. Add your local test domains (e.g. `".thunderstore.temp"`) in to env variable `__VITE_ADDITIONAL_SERVER_ALLOWED_HOSTS=`; like this `__VITE_ADDITIONAL_SERVER_ALLOWED_HOSTS=.thunderstore.temp`. (`localhost` is enabled by default) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this just be part of step 4? "Here's a example of file contents for development environment:"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanted to keep it as a separate step to pronounce the thought process of "what is the local domain I'll be using". I can change it if my thinking sounds weird
No description provided.