Skip to content

Update Nimbus README with enw allowedHosts setup #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Nimbus README with enw allowedHosts setup #1568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/cyberstorm-remix/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ VITE_AUTH_BASE_URL=http://thunderstore.temp
VITE_AUTH_RETURN_URL=http://new.thunderstore.temp
```

5. Uncomment the following string to the `allowedHosts` list in `vite.config.ts` ([link](https://github.com/thunderstore-io/thunderstore-ui/blob/f69ca05f2fe51320768aa4b934d17e40060192b5/apps/cyberstorm-remix/vite.config.ts#L13-L17)): `".thunderstore.temp"`
5. Add your local test domains (e.g. `".thunderstore.temp"`) in to env variable `__VITE_ADDITIONAL_SERVER_ALLOWED_HOSTS=`; like this `__VITE_ADDITIONAL_SERVER_ALLOWED_HOSTS=.thunderstore.temp`. (`localhost` is enabled by default)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this just be part of step 4? "Here's a example of file contents for development environment:"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to keep it as a separate step to pronounce the thought process of "what is the local domain I'll be using". I can change it if my thinking sounds weird



6. Run the build/start server script or the dev server script

Expand Down
Loading