Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transition to testthat 3e #479

Merged
merged 15 commits into from
Mar 7, 2023
Merged

transition to testthat 3e #479

merged 15 commits into from
Mar 7, 2023

Commits on Mar 7, 2023

  1. usethis::use_testthat(3)

    @simonpcouch
    simonpcouch committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    7081b7f View commit details
    Browse the repository at this point in the history

  2. remove calls to context()

    @simonpcouch
    simonpcouch committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    af0e8ab View commit details
    Browse the repository at this point in the history

  3. size -> linewidth (#477)

    @simonpcouch
    simonpcouch committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    3f827e1 View commit details
    Browse the repository at this point in the history

  4. address vdiffr path deprecation (#478) 

    we introduced this helper in #350 to satisfy a conditional usage requirement, but the default arguments to the wrapped function have changed in the meantime. it doesn't seem we ever set this argument to a non-default value.
    @simonpcouch
    simonpcouch committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    0e5ac14 View commit details
    Browse the repository at this point in the history

  5. expect_equivalent() -> expect_equal() 

    the algorithm for comparing differences with `tolerance` changed in the transition from 2e to 3e, so there were some new failures in `test-get_p_value.R`. i updated the expected value to reduce the absolute difference in those cases.
    @simonpcouch
    simonpcouch committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    a536c84 View commit details
    Browse the repository at this point in the history

  6. compare result rather than warning

    @simonpcouch
    simonpcouch committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    86fa11c View commit details
    Browse the repository at this point in the history

  7. address ggplot2 ..density.. deprecation warnings

    @simonpcouch
    simonpcouch committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    f351105 View commit details
    Browse the repository at this point in the history

  8. address change in expect_warning() output type

    @simonpcouch
    simonpcouch committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    a43ea70 View commit details
    Browse the repository at this point in the history

  9. brace test_that() expression

    @simonpcouch
    simonpcouch committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    53957e9 View commit details
    Browse the repository at this point in the history

  10. expect_is() -> expect_s3_class()

    @simonpcouch
    simonpcouch committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    15e9ece View commit details
    Browse the repository at this point in the history

  11. ignore attributes

    @simonpcouch
    simonpcouch committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    8df7535 View commit details
    Browse the repository at this point in the history

  12. expect_message() now returns message rather than result

    @simonpcouch
    simonpcouch committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    a0c2807 View commit details
    Browse the repository at this point in the history

  13. address deprecation of call map()ping

    @simonpcouch
    simonpcouch committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    f354db9 View commit details
    Browse the repository at this point in the history

  14. return result rather than message

    @simonpcouch
    simonpcouch committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    52c4057 View commit details
    Browse the repository at this point in the history

  15. test warning and result separately

    @simonpcouch
    simonpcouch committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    6859d37 View commit details
    Browse the repository at this point in the history