Skip to content

Typos and a few changes #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 12, 2018
Merged

Typos and a few changes #4

merged 12 commits into from
Sep 12, 2018

Conversation

DavisVaughan
Copy link
Member

Main changes:

  • Pulled reasoning for decoupling interface from computational code into the main text
  • Add an example of what a model method specification could look like
  • Added a note on how many .pred_{level} columns should be returned
  • Added .formula data arguments

Merge branch 'master' of https://github.com/topepo/model-implementation-principles

# Conflicts:
#	_book/model-predictions.html
#	_book/notes.html
#	_book/print-and-summary-methods.html
@DavisVaughan
Copy link
Member Author

@topepo this is ready now for whenever you want to review

@topepo topepo merged commit 865b5e8 into tidymodels:master Sep 12, 2018
@topepo
Copy link
Member

topepo commented Sep 12, 2018

Done. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants