Skip to content

adjust for cases where parsnip predictions are from a parsnip model #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 29, 2020

Conversation

topepo
Copy link
Member

@topepo topepo commented Feb 29, 2020

For hard class predictions and numeric predictions, the predict() method was having issues when the results were already in tidymodels-tibble format.

@codecov-io
Copy link

codecov-io commented Feb 29, 2020

Codecov Report

Merging #268 into master will decrease coverage by 0.02%.
The diff coverage is 55.55%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #268      +/-   ##
========================================
- Coverage   71.03%    71%   -0.03%     
========================================
  Files          38     38              
  Lines        2976   2980       +4     
========================================
+ Hits         2114   2116       +2     
- Misses        862    864       +2
Impacted Files Coverage Δ
R/predict_class.R 65.21% <0%> (-6.22%) ⬇️
R/predict.R 80% <100%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d992fc0...952575a. Read the comment docs.

@topepo topepo merged commit 670e75d into master Feb 29, 2020
@topepo topepo deleted the using-parsnip-models branch February 29, 2020 23:03
@github-actions
Copy link

github-actions bot commented Mar 7, 2021

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants