Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft deprecate liquidSVM engine #425

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Soft deprecate liquidSVM engine #425

merged 1 commit into from
Feb 4, 2021

Conversation

juliasilge
Copy link
Member

This PR soft deprecates the liquidSVM engine since it has been removed from CRAN and there has not been activity on its GitHub repo in about a year and a half.

library(parsnip)

svm_rbf(mode = "classification") %>%
  set_engine("liquidSVM")
#> Warning: The `engine` argument of `set_engine()` cannot be liquidSVM as of parsnip 0.1.6.
#> The liquidSVM package is no longer available on CRAN.
#> Radial Basis Function Support Vector Machine Specification (classification)
#> 
#> Computational engine: liquidSVM

Created on 2021-02-02 by the reprex package (v1.0.0)

I did this within set_engine() itself, which is a little weird (nothing model-specific is there) but it lets us use lifecycle to handle it, which I think is the best option.

@juliasilge juliasilge merged commit 481fb09 into master Feb 4, 2021
@juliasilge juliasilge deleted the deprecate-liquidsvm branch February 4, 2021 18:04
@github-actions
Copy link

github-actions bot commented Mar 6, 2021

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant