Make fit_xy() fail when mode is unknown #801
Conversation
There was a problem hiding this comment.
It is probably worth testing this against the book and the workshop notes? It seems like something that people could definitely accidentally rely on.
Also, I think you should be able to remove every usage of check_mode(), because mode is now required in all cases and is never inferred "automatically"
https://github.com/tidymodels/parsnip/search?q=check_mode
|
Checked against TMwR and revdeps. Everything looks good. |
|
Ok, I think we are good to move forward with this then. I'll go ahead and release workflows with this change. |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
As
fit()currently does.