Merged
Conversation
EmilHvitfeldt
commented
Dec 16, 2022
| cat("parsnip model object\n\n") | ||
| if (!is.na(x$elapsed[["elapsed"]])) { | ||
| cat("Fit time: ", prettyunits::pretty_sec(x$elapsed[["elapsed"]]), "\n") | ||
| if (is.null(x$elapsed$print)) { |
Member
Author
There was a problem hiding this comment.
I'm sure this can be rewritten better. If we go ahead with these functions then I'll clean it
This was referenced Dec 16, 2022
Merge commit 'a85e5083de0d1ec8087678cf21580690a37da81b' #Conflicts: # DESCRIPTION
simonpcouch
reviewed
Jun 16, 2023
hfrick
approved these changes
Jun 26, 2023
Member
hfrick
left a comment
hfrick
left a comment
There was a problem hiding this comment.
One comment on naming things (time of all things 🤪 )
Merge branch 'main' into extract_fit_time # Conflicts: # DESCRIPTION # NEWS.md # R/fit_helpers.R
simonpcouch
reviewed
Mar 27, 2024
simonpcouch
approved these changes
Apr 5, 2024
Contributor
simonpcouch
left a comment
simonpcouch
left a comment
There was a problem hiding this comment.
🏄 Just one similar docs edits with workflows.
Co-authored-by: Simon P. Couch <simonpatrickcouch@gmail.com>
Contributor
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of a series of PRs to add a new generic
extract_fit_time()to allow users to investigate how long different tidymodels objects takes to fit.TODO:
idclashed withidreturned fromtune_grid()Related PRs
tidymodels/hardhat#218
tidymodels/recipes#1071
tidymodels/workflows#191