Skip to content

load_libs() with engine == "earth" #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2023
Merged

load_libs() with engine == "earth" #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

* `.organize_glmnet_pred()` now expects predictions for a single penalty value (#876).

* Fixed bug where model fits with `engine = "earth"` would fail when the package's namespace hadn't been attached (#251).

* Fixed bug with prediction from a boosted tree model fitted with `"xgboost"` using a custom objective function (#875).

* Several internal functions (to help work with `Surv` objects) were added as a standalone file that can be used in other packages via `usethis::use_standalone("tidymodels/parsnip")`.
Expand Down
3 changes: 3 additions & 0 deletions R/mars.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ translate.mars <- function(x, engine = x$engine, ...) {
message("Used `engine = 'earth'` for translation.")
engine <- "earth"
}
if (engine == "earth") {
load_libs(x, quiet = TRUE, attach = TRUE)
}
# If classification is being done, the `glm` options should be used. Check to
# see if it is there and, if not, add the default value.
if (x$mode == "classification") {
Expand Down