Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit uses of tibble() and as_tibble() #923

Merged
merged 1 commit into from
Mar 16, 2023
Merged

audit uses of tibble() and as_tibble() #923

merged 1 commit into from
Mar 16, 2023

Conversation

simonpcouch
Copy link
Contributor

Same idea as tidymodels/tune#637. :) Only implemented in model registration code—this doesn't have much of a user-facing effect, but makes devtools::load_all() feel a bit snappier.

bench::mark(
  load_all = devtools::load_all()
)
#> ℹ Loading parsnip
#> # A tibble: 1 × 13
#>   expression      min   median itr/s…¹ mem_a…² gc/se…³ n_itr  n_gc total…⁴
#>   <bch:expr> <bch:tm> <bch:tm>   <dbl> <bch:b>   <dbl> <int> <dbl> <bch:t>
#> 1 load_all       1.9s     1.9s   0.526  26.6MB    3.68     1     7    1.9s
#> # … with 4 more variables: result <list>, memory <list>, time <list>,
#> #   gc <list>, and abbreviated variable names ¹​`itr/sec`, ²​mem_alloc,
#> #   ³​`gc/sec`, ⁴​total_time
#> # ℹ Use `colnames()` to see all variable names

With this PR:

#> # A tibble: 1 × 13
#>   expression      min   median itr/s…¹ mem_a…² gc/se…³ n_itr  n_gc total…⁴
#>   <bch:expr> <bch:tm> <bch:tm>   <dbl> <bch:b>   <dbl> <int> <dbl> <bch:t>
#> 1 load_all      1.53s    1.53s   0.639    26MB    3.10     1     5   1.61s
#> # … with 4 more variables: result <list>, memory <list>, time <list>,
#> #   gc <list>, and abbreviated variable names ¹​`itr/sec`, ²​mem_alloc,
#> #   ³​`gc/sec`, ⁴​total_time
#> # ℹ Use `colnames()` to see all variable names

@simonpcouch simonpcouch requested a review from hfrick March 14, 2023 12:58
@simonpcouch simonpcouch merged commit e2b9baa into main Mar 16, 2023
@simonpcouch simonpcouch deleted the tibble branch March 16, 2023 12:51
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants