speed up spec_is_possible()
helper
#932
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My old helper was slow🦥 Instead of joining, we can perform the filtering on the separate datasets, and with vctrs instead of dplyr. For a quick model fit on a small dataset, this cuts down fit time by ~22%!
With
main
dev:With this PR:
Created on 2023-03-17 with reprex v2.0.2
There are additional tests for this infrastructure in extratests—they are fine. :)