Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write out dplyr_pre_1.0.0 helper #645

Closed
simonpcouch opened this issue Mar 20, 2023 · 1 comment · Fixed by #649
Closed

write out dplyr_pre_1.0.0 helper #645

simonpcouch opened this issue Mar 20, 2023 · 1 comment · Fixed by #649
Labels
upkeep maintenance, infrastructure, and similar

Comments

@simonpcouch
Copy link
Contributor

We now use

tune/DESCRIPTION

Line 22 in 009b433

dplyr (>= 1.0.8),

We thus ought to write out the dplyr_pre_1.0.0 helper:

tune/R/compat-dplyr-old.R

Lines 1 to 3 in 009b433

dplyr_pre_1.0.0 <- function() {
utils::packageVersion("dplyr") <= "0.8.5"
}

@simonpcouch simonpcouch added the upkeep maintenance, infrastructure, and similar label Mar 20, 2023
@simonpcouch simonpcouch mentioned this issue Mar 20, 2023
Merged
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

write out dplyr_pre_1.0.0() helper tidymodels/tune
1 participant
@simonpcouch