Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more maximize. Closes #172. #176

Merged
merged 10 commits into from Feb 27, 2020
Merged

Conversation

juliasilge
Copy link
Member

There's a new little function is_metric_maximize() that gets called before check_metric_choice() now.

@topepo
Copy link
Member

topepo commented Feb 24, 2020

Please add a note to the NEWS file.

@juliasilge
Copy link
Member Author

OK, I think this is actually ready for review now @topepo. 💃

@topepo
Copy link
Member

topepo commented Feb 26, 2020

Looks good with one suggested change. I ran the conf notes through this version and I think that the message(which I thought was fine before) is a little "inside baseball". Can you change:

Ignored the maximize argument. Direction is built in to each metric set.

to something like

The maximize argument is no longer needed. This value was ignored.

After that, we are 💯

@topepo topepo merged commit 450cb63 into tidymodels:master Feb 27, 2020
@juliasilge juliasilge deleted the no-more-maximize branch February 27, 2020 21:58
@github-actions
Copy link

github-actions bot commented Mar 8, 2021

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants