Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
metrics_info
helper is a small helper to reformatas_tibble.metric_set
for easier filtering/selecting. It's reasonably fast, but was called in a couple places inside thetune_grid_loop_iter
interior loops, so ends up being called thousands of times even for small grid searches. We can thus pre-compute that output and pass it as an argument totune_grid_loop_iter
. Note that this introduces merge conflicts with #641—glad to take care of that once we get there.With
main
dev:...with a 4% decrease in evaluation time with this PR:
That effect is more substantial when tuning hyperparameters. :)
Created on 2023-03-17 with reprex v2.0.2