Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-disconnect SQLite connection #2878

Merged
merged 1 commit into from
Jun 16, 2017
Merged

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Jun 16, 2017

because DBI specs ask for a warning if a client forgets to disconnect.

I'm aware that RSQLite connections are cheap compared to connections to other DBMS, but I prefer a uniform interface definition.

because DBI specs ask for a warning if a client does not disconnect
@krlmlr krlmlr requested a review from hadley June 16, 2017 07:36
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks.

@krlmlr krlmlr merged commit b0320c8 into tidyverse:master Jun 16, 2017
@krlmlr krlmlr deleted the b-auto-disconnect branch June 16, 2017 13:22
@lock
Copy link

lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants