-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates theme-defaults.r (#1555) #1557
Conversation
addresses issue tidyverse#1555 - elements added in new theme inherit "element_blank"
fixes tidyverse#1555)
@@ -33,6 +33,8 @@ | |||
|
|||
## Bug fixes | |||
|
|||
* All elements should now inherit correctly for all themes except theme_void(). (@Katiedaisey, #1555) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind alphabetising this under theme_void()
Should be fixed |
Updates theme-defaults.r (#1555)
Thanks - much appreciated :). |
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
addresses issue #1555 where some elements added under certain themes inherit "element_blank" and cannot be updated, e.g.
ggplot(mtcars, aes(wt, mpg)) + geom_point() + theme_classic() + theme(panel.grid.major.y = element_line(colour = "pink", size = 4))
update explicitly declares parent element as necessary and children elements as element_blank