New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geom_dotplot negates free y scale from facet_wrap #1618

Closed
aosmith16 opened this Issue Apr 21, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@aosmith16

aosmith16 commented Apr 21, 2016

When binning the dotplot on the y axis, the facet_wrap free y scale is negated. This is new behavior - is it by design?

library(ggplot2)

p1 = ggplot(mtcars, aes(factor(cyl), mpg)) +
    geom_boxplot() +
    facet_wrap(~am, scales = "free_y")
p1

rplot
p1 + geom_dotplot(binaxis = "y")

rplot01

@has2k1

This comment has been minimized.

Contributor

has2k1 commented Apr 24, 2016

This is probably due to the removal of stat_dotplot. Now the binning is happening across the entire layer i.e in setup_data instead of happening per panel.

edit: My recollection was off when I tried to make sense of this initially. I have fixed the issue in PR #1622.

has2k1 added a commit to has2k1/ggplot2 that referenced this issue Apr 26, 2016

Fix geom_dotplot y limit calculations
The computed y limits depend on both the group & panel.
This ensures that the scale trainning does not get wrong
(global y limits) input.

Fixes tidyverse#1618

@hadley hadley added the in progress label Jul 28, 2016

has2k1 added a commit to has2k1/ggplot2 that referenced this issue Aug 24, 2016

Fix geom_dotplot y limit calculations
The computed y limits depend on both the group & panel.
This ensures that the scale trainning does not get wrong
(global y limits) input.

Fixes tidyverse#1618

@hadley hadley closed this in aebbece Sep 6, 2016

@hadley hadley removed the in progress label Sep 6, 2016

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.