Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update input checks to use rlang type checking #4834

Closed
thomasp85 opened this issue May 9, 2022 · 1 comment · Fixed by #5209
Closed

Update input checks to use rlang type checking #4834

thomasp85 opened this issue May 9, 2022 · 1 comment · Fixed by #5209

Comments

@thomasp85
Copy link
Member

This is an issue that is mostly about code sanitising. The code base is littered with checks for e.g. various types of scalars etc for which rlang now provides good self-documenting checks.

@teunbrand
Copy link
Collaborator

Another pattern that is very common and could be wrapped is the following:

if (!input_has_class(input)) {
  abort("Input should have class xyz")
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants