Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added xlim and ylim arguments to borders() #1392

Merged
merged 3 commits into from Nov 9, 2015
Merged

Added xlim and ylim arguments to borders() #1392

merged 3 commits into from Nov 9, 2015

Conversation

@markpayneatwork
Copy link
Contributor

@markpayneatwork markpayneatwork commented Oct 27, 2015

The borders() function is extremely handy if you are working with geographical data but the specification of the geographical region-of-interest is limited to defining regions via text strings i.e. via the regions="" argument. However, both the maps::map() function and ggplot2::map_data() accept geographic region specification using xlim and ylim arguments. This modification extemds that functionality to borders()

@@ -74,6 +74,7 @@ map_data <- function(map, region = ".", exact = FALSE, ...) {
#' @param regions map region
#' @param fill fill colour
#' @param colour border colour
#' @param "xlim, ylim" map xlim and ylim,, see \code{\link[maps]{map}} for details
Copy link
Member

@hadley hadley Oct 27, 2015

should be xlim,ylim

@hadley
Copy link
Member

@hadley hadley commented Oct 27, 2015

Could you please also add a bullet point to NEWS?

@markpayneatwork
Copy link
Contributor Author

@markpayneatwork markpayneatwork commented Oct 27, 2015

Have updated the branch to match the style, and added a NEWS item. Hope this is all ok.

@hadley hadley merged commit ae8937b into tidyverse:master Nov 9, 2015
1 check failed
@hadley
Copy link
Member

@hadley hadley commented Nov 9, 2015

Thanks!

@markpayneatwork
Copy link
Contributor Author

@markpayneatwork markpayneatwork commented Nov 9, 2015

You're welcome - I'm pleased to be able to contribute something bac to
such a brilliant package - thank you for putting it together!

Mark

On 09/11/15 21:05, Hadley Wickham wrote:

Thanks!


Reply to this email directly or view it on GitHub
#1392 (comment).

Mark Payne
Senior Researcher
Centre for Ocean Life

DTU Aqua

Technical University of Denmark
National Institute of Aquatic Resources
Charlottenlund Slot,
Jægersborg Allé 1
2920 Charlottenlund
Direct +45 35883422
mpay@aqua.dtu.dk
http://www.aqua.dtu.dk/mpay
@markpayneatwork
Skype: MarkPayneAtWork

@lock
Copy link

@lock lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants