Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outlier.fill added to geom_boxplot #1787

Closed
wants to merge 8 commits into from

Conversation

@schloerke
Copy link
Contributor

@schloerke schloerke commented Sep 27, 2016

Fixes #1785

Before (no fill color in points):
screen shot 2016-09-27 at 4 22 15 pm

New output:

load_all(); ggplot(iris, aes(Species, Sepal.Width, fill = Species)) + geom_boxplot(outlier.shape = 21)

screen shot 2016-09-27 at 4 15 23 pm

@@ -1,92 +1,97 @@
# ggplot2 2.1.0.9000
# ggplot2 2.1.0.9000

This comment has been minimized.

@hadley

hadley Oct 5, 2016
Member

Could you please fix up these spurious ws changes?

Analogous to outlier.colour, outlier.shape, etc.
(@jonathan-g).

* `geom_boxplot` gain new `outlier.fill` argument for controlling the fill of

This comment has been minimized.

@hadley

hadley Oct 5, 2016
Member

Can you put the new news at the top please?

schloerke added 4 commits Oct 6, 2016
* master: (30 commits)
  Elucidate & implement consistent principles for discrete NA
  Change meaning of trim (#1802)
  Document strip.placement theme setting
  Style tweaks for theme()
  More sophisticated facet var evaluation strategy
  Teach rd_aesthetics about optional aesthetics
  Allow defintion of optional aes
  Link to geom_count from geom_point help
  Improve geom_density docs.
  Support hms position scales
  Correct aesthetic specs for bar charts
  Add check.aes and check.param args to layer()
  Handle sign transforming transformations
  Axis labels should always be character
  Only format numbers
  Update revdep email
  Re-run revdeps
  Run revdep check
  fix stacking (#1817)
  Fix axis names for FacetNull (#1814)
  ...
@schloerke
Copy link
Contributor Author

@schloerke schloerke commented Oct 6, 2016

@hadley I've removed all extra changes!

(current travis failures are not due to this PR's changes as they passed earlier)

@hadley hadley closed this in 9e4218a Oct 6, 2016
@hadley
Copy link
Member

@hadley hadley commented Oct 6, 2016

Thanks!

@hadley hadley reopened this Oct 6, 2016
@hadley hadley closed this Oct 7, 2016
@lock
Copy link

@lock lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants