Add room around guide title #2195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you may want to review guide-colorbar.R for consistency |
|
@karawoo yes please! |
hadley
approved these changes
Jul 6, 2017
karawoo
added a commit
to karawoo/ggplot2
that referenced
this pull request
Jul 14, 2017
* Add room around guide title (@baptiste) * Update visual test SVGs * Update hgap and vgap in guide-colorbar.r to match guide-legend.r * New visual test SVGs to reflect modified legends in guide-colorbar.r
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is @baptiste's change from #1882, but it breaks the visual tests because the spacing between the title and legend elements is slightly changed. @hadley should I validate those with
vdiffrand commit the new SVGs?