Compute overlapping groups by panel #2562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karawoo
requested changes
May 10, 2018
There was a problem hiding this comment.
This looks great for bars/boxes/etc. but for interval geoms the vapply() fails because find_x_overlaps() sometimes returns a vector of length >1. See the following reprex which works on master but fails with this PR:
# On master
library("ggplot2")
df <- tibble::tibble(
xmin = c(1, 3, 6),
xmax = c(5, 7, 9),
ymin = c(1, 1, 5),
ymax = c(3, 4, 8),
fill = c("a", "b", "c")
)
ggplot(df, aes(xmin = xmin, xmax = xmax, ymin = ymin, ymax = ymax, fill = fill)) +
geom_rect(alpha = 0.8, position = position_dodge2(preserve = "single"))
With the changes from this PR:
ggplot(df, aes(xmin = xmin, xmax = xmax, ymin = ymin, ymax = ymax, fill = fill)) +
geom_rect(alpha = 0.8, position = position_dodge2(preserve = "single"))
#> Error in vapply(panels, find_x_overlaps, double(1)): values must be length 1,
#> but FUN(X[[1]]) result is length 3| n <- max(table(find_x_overlaps(data))) | ||
| panels <- unname(split(data, data$PANEL)) | ||
| if ("x" %in% names(data)) { | ||
| # Point geom |
There was a problem hiding this comment.
This comment confused me for a minute as I thought it was only running for geom_point()
|
Thanks for catching that - should be resolved now. |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2493
@karawoo can you please double check my logic? I think this makes sense as we should only be considering the maximum number of overlapping groups within a panel.