fix a typo in NEWS.md

[yutannihilation]

No description provided.

[clauswilke]

The typo fix looks good to me.

However, (probably more a comment to @hadley), I don't understand the following phrase:
"use quo_name() (for shorter labels) or quo_text() (if you want everything)."

Even after reading the documentation for quo_name() and quo_text() I don't know what this means. Specifically, I'm wondering, what is a "short" label (where I'd use quo_name()) and what is "everything"? Can we rephrase this?

[yutannihilation]

Yeah, I too felt the phase mysterious, but I found what a "short" label is in ?quo_label():

# quo_name() is helpful when you need really short labels:
quo_name(quo(sym))
#> [1] "sym"
quo_name(quo(!! sym))
#> [1] "function (x) ..."

I'm still not sure about the actual use cases, but maybe this is useful when you create a label by deparsing an aes that is not a simple symbol and contains unquoted functions in its expression?

[clauswilke]

I think talking about "short" symbols is misleading:

quo_name(quo(this_is_a_really_long_symbol_and_quo_name_has_no_problem_with_it))
#> [1] "this_is_a_really_long_symbol_and_quo_name_has_no_problem_with_it"
quo_text(quo(this_is_a_really_long_symbol_and_quo_name_has_no_problem_with_it))
#> [1] "this_is_a_really_long_symbol_and_quo_name_has_no_problem_with_it"

quo_name() and quo_text() seem to return the same result for symbols but different results for expressions. For expressions, at some point quo_name() starts to abbreviate but quo_text() keeps going:

quo_name(quo(a + b + c + d + e + f + g + h + i + j + k + l + m + n + o + p))
#> [1] "a + b + c + d + e + f + g + h + i + j + k + l + m + n + o + p"
quo_name(quo(a + b + c + d + e + f + g + h + i + j + k + l + m + n + o + p + q))
#> [1] "+..."
quo_text(quo(a + b + c + d + e + f + g + h + i + j + k + l + m + n + o + p + q))
#> [1] "a + b + c + d + e + f + g + h + i + j + k + l + m + n + o + p + \n    q"

[hadley]

Yeah, it's long expressions that are shortened, not long symbols. We need to document this better in rlang; I think it's ok if it's slightly bewildering in the NEWS file — at least it gets people looking in the right direction (although better wording is, of course, appreciated)

[clauswilke]

How about:

use quo_name() (to generate single-line strings; longer expressions may be abbreviated) or quo_text() (to generate non-abbreviated strings that may span multiple lines)

[hadley]

👍

[yutannihilation]

@clauswilke Thanks for the nice sentence! Should I include this? If you will create another PR, I'll close this here.

[clauswilke]

Yes, just include it in your PR. Thanks!

[yutannihilation]

Sure!

[yutannihilation]

Done.

[hadley]

Thanks!

[lock]

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/