Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only print the names of the aesthetics with mismatched length #2853

Merged
merged 2 commits into from Aug 24, 2018

Conversation

karawoo
Copy link
Member

@karawoo karawoo commented Aug 23, 2018

Found when looking at #2850. The error message in compute_aesthetics() should show the names of aesthetics with mismatched lengths, but as written it showed the names of all aesthetics.

@karawoo karawoo requested a review from hadley August 23, 2018 22:26
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worthy of a news bullet

@karawoo karawoo merged commit adce4e2 into tidyverse:master Aug 24, 2018
@karawoo karawoo deleted the aes-names branch August 24, 2018 17:58
@lock
Copy link

lock bot commented Feb 20, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Feb 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants