New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only print the names of the aesthetics with mismatched length #2853

Merged
merged 2 commits into from Aug 24, 2018

Conversation

Projects
None yet
2 participants
@karawoo
Member

karawoo commented Aug 23, 2018

Found when looking at #2850. The error message in compute_aesthetics() should show the names of aesthetics with mismatched lengths, but as written it showed the names of all aesthetics.

@karawoo karawoo requested a review from hadley Aug 23, 2018

@hadley

hadley approved these changes Aug 23, 2018

Probably worthy of a news bullet

@karawoo karawoo merged commit adce4e2 into tidyverse:master Aug 24, 2018

4 checks passed

codecov/patch 100% of diff hit (target 77.62%)
Details
codecov/project 77.62% (+0%) compared to 01155ba
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@karawoo karawoo deleted the karawoo:aes-names branch Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment