Broad review of governance structure #2961

hadley · 2018-10-25T15:50:02Z

I've removed some duplication, and attempted to refine the description of the different categories of community member. I've also moved away from the "benevolent dictator" language in favour of "project lead".

What other important parts of the ggplot2 governance process have I forgotten?

hadley · 2018-10-25T15:56:12Z

@jennybc would you mind also taking a look?

jennybc · 2018-10-25T20:56:40Z

GOVERNANCE.md

+
+## Core developers
+
+Core developers are GitHub administrators and [package authors](https://github.com/tidyverse/ggplot2/blob/master/DESCRIPTION#L8). This means that they have the ability of make changes to project code, and receive credit when others cite the package.


"ability TO make changes"

karawoo

This all looks good to me. I wonder if we should reiterate here that we have a code of conduct, and possibly talk about how it is/will be enforced. For example, our CoC says that maintainers who do not follow the CoC may be removed from the team, which seems relevant to include here.

GOVERNANCE.md

karawoo · 2018-10-26T16:22:51Z

GOVERNANCE.md


 ## Users
-Users are community members who have a need for the project. They are the most important members of the community: without them, the project would have no purpose. Anyone can be a user; there are no specific requirements.
+
+Users are community members who use the package, without interacting with GitHub. They are the most important members of the community: without them, the project would have no purpose. 


Since the users are the most important, maybe the order of these sections should be reversed so they come first.

Co-Authored-By: hadley <h.wickham@gmail.com>

…vernance

hadley · 2018-10-26T21:19:42Z

@karawoo funnily enough I had already added CoC cross-refs but I forgot to push!

gvwilson · 2018-10-27T13:06:09Z

.github/CODE_OF_CONDUCT.md

@@ -18,7 +18,7 @@ Code of Conduct. Project maintainers who do not follow the Code of Conduct may b
 from the project team.

 Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by 
-opening an issue or contacting one or more of the project maintainers.
+opening an issue or contacting the project lead or one of the core developers.


Add a contact email address or an alias that re-routes to one or more people.

gvwilson · 2018-10-27T13:06:43Z

GOVERNANCE.md

-# Roles And Responsibilities
-## Benevolent dictator (Hadley Wickham, @hadley)
-The job of the benevolent dictator is to set the strategic objectives of the project and communicate these clearly to the community, ensuring that the project survives in the long term. 
+This project has a large community __users__ and __contributors__, a team of __core developers__, and a __project lead__.


large community of

GOVERNANCE.md

gvwilson · 2018-10-27T13:08:55Z

GOVERNANCE.md

+- asking and answering on community forums
+- providing moral support (a 'thank you' goes a long way)
+
+Users who continue to engage with the project and its community will often find themselves becoming more and more involved. Such users may then go on to become contributors, as described above.


Users will often find themselves becoming more and more involved with the project and its community.

GOVERNANCE.md

gvwilson · 2018-10-27T13:16:05Z

GOVERNANCE.md

-of conflict, the project lead’s word is final. If the community chooses to question
-the wisdom of the actions of a core developer, the project lead can review their
-decision, and either uphold or reverse them.
+This project makes decisions according to a consensus model where suggestions are considered and discussed between the community and core developers. In case of conflict, the project lead’s word is final. If the community chooses to question the wisdom of the actions of a core developer, the project lead can review their decision, and either uphold or reverse them.


This project makes decisions by consensus: suggestions are considered and discussed by the community and core developers. [question: where does discussion take place? in issue threads? mailing list?] Where consensus cannot be reached, the project lead's word is final. If the community questions a decision, the project lead may review it and either uphold or reverse it.

hadley · 2018-10-29T21:10:41Z

@batpigandme can you please give this a final proofread?

batpigandme

Good stuff. Just a couple renegade words, and some highly-opinionated grammar suggestions.

batpigandme · 2018-10-29T21:22:32Z

.github/CODE_OF_CONDUCT.md

@@ -18,7 +18,7 @@ Code of Conduct. Project maintainers who do not follow the Code of Conduct may b
 from the project team.

 Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by 
-opening an issue or contacting one or more of the project maintainers.
+opening an issue or contacting the project lead or one of the core developers.


comma after "opening an issue"

batpigandme · 2018-10-29T21:23:08Z

GOVERNANCE.md

-Core developers are contributors who have made several valuable contributions to the project and are now relied upon to write code directly to the repository and screen the contributions of others. Core developers are empowered to merge pull requests after careful review. Core developers have no authority over the overall direction of the project, however it is their job to help develop or elicit appropriate contributions to the project. As a matter of policy, core developers, even if no longer active, are listed (chronologically) in [package authors](https://ggplot2.tidyverse.org/authors.html).
+## Users
+
+People who create visualizations with ggplot2 are the most important members of the community; with these users, this project would have no purpose.


without these users?

batpigandme · 2018-10-29T21:26:27Z

GOVERNANCE.md

- evangelising about the project
- informing developers of project strengths and weaknesses from a new user’s perspective
- providing moral support (a ‘thank you’ goes a long way)
+Core developers are recruited from contributors. An invitation to join the core team can be extended to anyone who has made a major contribution, either through a small number of large changes, or a consistent pattern of smaller contributions. Any existing core developer can propose a contributor be invited to the core team by emailing the project lead. The project lead will the confirm the invitation with existing core developers.


Remove extra the in last sentence (I think you want The project lead will confirm the invitation)

batpigandme · 2018-10-29T21:28:40Z

GOVERNANCE.md

+
+The project lead, [Hadley Wickham](http://github.com/hadley), is responsible for:
+
+* Setting, and clearly communication the strategic objectives of the project.


I defer to the project lead (obvi), but since these bullets aren't actually sentences, I'd do semicolons (or commas) and an "and" before the last one.

hadley · 2018-10-29T21:35:23Z

Thanks everyone!

batpigandme · 2018-10-29T21:37:00Z

GOVERNANCE.md

@@ -32,7 +32,7 @@ Core developers are collectively responsible for day-to-day development of the p

 While core developers can modify code directly, this ability is rarely used. Instead, changes are proposed as pull requests, and are only merged after they have been reviewed by at least one other core developer. Changes to the API (especially breaking changes) must also be approved by the project lead. 

-Core developers are recruited from contributors. An invitation to join the core team can be extended to anyone who has made a major contribution, either through a small number of large changes, or a consistent pattern of smaller contributions. Any existing core developer can propose a contributor be invited to the core team by emailing the project lead. The project lead will the confirm the invitation with existing core developers.
+Core developers are recruited from contributors. An invitation to join the core team can be extended to anyone who has made a major contribution, either through a small number of large changes, or a consistent pattern of smaller contributions. Any existing core developer can propose a contributor be invited to the core team by emailing the project lead. The project lead will the confirm the invitation with the other core developers.


You still have "The project lead will the confirm the invitation with the other core developers."

Because that's what will happen 😄

Suggested change

Core developers are recruited from contributors. An invitation to join the core team can be extended to anyone who has made a major contribution, either through a small number of large changes, or a consistent pattern of smaller contributions. Any existing core developer can propose a contributor be invited to the core team by emailing the project lead. The project lead will the confirm the invitation with the other core developers.

Core developers are recruited from contributors. An invitation to join the core team can be extended to anyone who has made a major contribution, either through a small number of large changes, or a consistent pattern of smaller contributions. Any existing core developer can propose a contributor be invited to the core team by emailing the project lead. The project lead will confirm the invitation with the other core developers.

lock · 2019-04-27T21:47:07Z

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

Broad review of governance structure

032f3d4

jennybc approved these changes Oct 25, 2018

View reviewed changes

hadley mentioned this pull request Oct 26, 2018

Describe process by which a contributor can become a core developer #2959

Merged

Cross-link governance with code of conduct

2faac1e

karawoo reviewed Oct 26, 2018

View reviewed changes

karawoo and others added 2 commits October 26, 2018 16:03

Update GOVERNANCE.md

12f73ae

Co-Authored-By: hadley <h.wickham@gmail.com>

git Merge branch 'governance' of github.com:tidyverse/ggplot2 into go…

e174cf6

…vernance

More governance writing

9e90cad

gvwilson reviewed Oct 27, 2018

View reviewed changes

GOVERNANCE.md Outdated Show resolved Hide resolved

gvwilson reviewed Oct 27, 2018

View reviewed changes

GOVERNANCE.md Outdated Show resolved Hide resolved

gvwilson reviewed Oct 27, 2018

View reviewed changes

GOVERNANCE.md Outdated Show resolved Hide resolved

gvwilson reviewed Oct 27, 2018

View reviewed changes

hadley force-pushed the governance branch from 8acf7e1 to 9e90cad Compare October 27, 2018 13:17

More governance tweaks

40db7c3

batpigandme approved these changes Oct 29, 2018

View reviewed changes

Final governance tweaks

e3ecd7d

hadley merged commit 0e29a19 into master Oct 29, 2018

hadley deleted the governance branch October 29, 2018 21:35

batpigandme reviewed Oct 29, 2018

View reviewed changes

karawoo mentioned this pull request Oct 29, 2018

Fix extraneous "the" in GOVERNANCE.md #2968

Closed

lock bot locked and limited conversation to collaborators Apr 27, 2019


		## Core developers

		Core developers are GitHub administrators and [package authors](https://github.com/tidyverse/ggplot2/blob/master/DESCRIPTION#L8). This means that they have the ability of make changes to project code, and receive credit when others cite the package.


		The project lead, [Hadley Wickham](http://github.com/hadley), is responsible for:

		* Setting, and clearly communication the strategic objectives of the project.

Broad review of governance structure #2961

Broad review of governance structure #2961

Uh oh!

Conversation

hadley commented Oct 25, 2018

Uh oh!

hadley commented Oct 25, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

karawoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hadley commented Oct 26, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hadley commented Oct 29, 2018

Uh oh!

batpigandme left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hadley commented Oct 29, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lock bot commented Apr 27, 2019

Uh oh!

Uh oh!