Skip to content

Issue 3088 sf reorg #3111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 1, 2019
Merged

Conversation

clauswilke
Copy link
Member

This PR breaks sf.R into four separate files, coord-sf.R, geom-sf.R, layer-sf.R, and stat-sf.R, so individual pieces of sf code become easier to find. No other changes to the code were done.

Copy link
Member

@yutannihilation yutannihilation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Some comments might not be needed anymore.

R/stat-sf.R Outdated
@@ -0,0 +1,43 @@
# stat --------------------------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. Done.

@clauswilke
Copy link
Member Author

@hadley @thomasp85 Any concerns? Otherwise I'd like to go ahead and merge.

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the whitespaces I have no comments/objections

R/coord-sf.R Outdated
ndiscr = ndiscr,
expand = expand,
default = default,
clip = clip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid adding these whitespaces... consensus seems to be to not indent ggproto definitions more than 2 spaces

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will fix. When I move ggproto code around in RStudio it always has its own opinion on indentation. I thought I had caught all these cases but apparently I didn't.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm acutely aware of what you mean :-)

@clauswilke clauswilke merged commit 863ff94 into tidyverse:master Feb 1, 2019
@clauswilke clauswilke deleted the issue-3088-sf-reorg branch February 1, 2019 16:23
@lock
Copy link

lock bot commented Jul 31, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants