-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Issue 3088 sf reorg #3111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 3088 sf reorg #3111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Some comments might not be needed anymore.
R/stat-sf.R
Outdated
@@ -0,0 +1,43 @@ | |||
# stat -------------------------------------------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this. Done.
@hadley @thomasp85 Any concerns? Otherwise I'd like to go ahead and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than the whitespaces I have no comments/objections
R/coord-sf.R
Outdated
ndiscr = ndiscr, | ||
expand = expand, | ||
default = default, | ||
clip = clip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid adding these whitespaces... consensus seems to be to not indent ggproto definitions more than 2 spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, will fix. When I move ggproto code around in RStudio it always has its own opinion on indentation. I thought I had caught all these cases but apparently I didn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm acutely aware of what you mean :-)
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
This PR breaks
sf.R
into four separate files,coord-sf.R
,geom-sf.R
,layer-sf.R
, andstat-sf.R
, so individual pieces of sf code become easier to find. No other changes to the code were done.