Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the range of recognised positional aesthetics #3168

Merged
merged 2 commits into from Mar 4, 2019

Conversation

@thomasp85
Copy link
Member

@thomasp85 thomasp85 commented Feb 28, 2019

This PR extends the recognised positional aesthetics to include x0 and y0. This is needed for a range of geoms/stats in ggforce to make sure they play nice with scale transformations. x0 and y0 are traditionally used to denote center values and a natural fit for many parametrised geometries...

Such a change has happened before in c9f276b so it should be fairly safe

Copy link
Member

@clauswilke clauswilke left a comment

I think this is fine, but I would recommend adding a news item that mentions this, since it could be a breaking change if somebody somewhere was using an x0 or y0 aesthetic in a non-position sense.

Copy link
Member

@yutannihilation yutannihilation left a comment

Looks good.

@yutannihilation
Copy link
Member

@yutannihilation yutannihilation commented Mar 1, 2019

By the way, these (what aesthetics are treated as positional) are the official spec of ggplot2? If so, I think it should be described in the docs (and I'll do it in a seperate PR).

@thomasp85
Copy link
Member Author

@thomasp85 thomasp85 commented Mar 4, 2019

You can see the list of recognised position aesthetics in the construction of the continuous position scales...

@thomasp85 thomasp85 merged commit 72e04b1 into tidyverse:master Mar 4, 2019
4 checks passed
@yutannihilation
Copy link
Member

@yutannihilation yutannihilation commented Mar 4, 2019

Yeah, but I still think it's nice to have it documented (and probably needs tests), though I have no idea where those developer-only documentaton should go (Extending ggplot2?)...

@lock
Copy link

@lock lock bot commented Aug 31, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants