-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Test R 4.0 on CI #3961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test R 4.0 on CI #3961
Conversation
I generally think it is better to be explicit with what versions you are checking rather than using the aliases. One reason is that you will have to bump the cache numbers to invalidate the cache when the versions change anyway, so if you have to edit the yaml anyway might as well make it very clear what versions you are checking against. |
Thanks! It makes sense. I was wondering why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me but I don't know whether I'm the right person to review. Questions to which I don't know the answer:
-
Do we want to change the R version requirement for an upcoming minor release (presumably ggplot2 3.3.1 should come out soon)?
-
Do we always increase the version in Depends when we drop supported versions? As far as I can tell, there's no change in the code that causes ggplot2 to break for R 3.2, we're just not checking anymore.
Aw, true. Sorry, probably I should have asked Hadley and Thomas.
Yes, since the second next release (currently expected as "v3.4.0") should be distant, I thought we should be clear about dropping the support in the next version to prevent confusion.
Yes, I think we are supposed to increase it even if there's no actual breakage, but I might misunderstand the rule of tidyverse. @hadley @thomasp85 |
No, you don't need to bump the minor version of the required version of R unless there is something you use in ggplot2 that would require it. |
Oh, sorry. I misunderstood the process... Then, should I keep the R 3.2 runner to know when we actually need to drop the support? |
@yutannihilation Yes. Generally what we do is keep the dependency and runners as is (just adding a new one for the latest version), and then only drop when we have to (i.e. when you use a function or package that needs 3.3). We should really document this process somewhere 😬 |
@hadley @clauswilke |
Now R 4.0.0 is released,
let's drop support for R 3.2 (c.f. we support only 4 previous versions of R https://www.tidyverse.org/blog/2019/04/r-version-support/).let's add R 4.0 runners on CIIn addition, this PR contains the following tweaks:
cran:libgit2
PPA to avoid conflicts related tolibcurl4-gnutls-dev
(c.f. Dependency on gert triggers preperror during rhub::check_for_cran() r-hub/sysreqsdb#77 (comment))