Skip to content

Remove filename from the call to custom devices if file is present in the formals #4674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Remove filename from the call to custom devices if file is present in the formals #4674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e618317
Remove filename from the call to custom devices if file is present in…
thomasp85 Nov 17, 2021
c3bbbc4
Merge branch 'main' into issue-4539-ggsave-filename
thomasp85 Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# ggplot2 (development version)

* Better compatibility of custom device functions in `ggsave()`
(@thomasp85, #4539)

* Binning scales are now more resilient to calculated limits that ends up being
`NaN` after transformations (@thomasp85, #4510)

Expand Down
1 change: 1 addition & 0 deletions R/save.r
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ plot_dev <- function(device, filename = NULL, dpi = 300) {
call_args <- list()
if ("file" %in% names(args)) {
call_args$file <- filename
call_args["filename"] <- list(NULL)
}
if ("res" %in% names(args)) {
call_args$res <- dpi
Expand Down