Skip to content

Conversation

yutannihilation
Copy link
Member

A small followup of #4868.

I found this warning on our CI.

* checking R code for possible problems ... NOTE
Warning: Warning: <anonymous>: ... may be used in an incorrect context: ‘list(...)’ (/home/runner/work/ggplot2/ggplot2/check/ggplot2.Rcheck/00_pkg_src/ggplot2/R/save.r:176)
plot_dev: ... may be used in an incorrect context: ‘list(...)’
  (/home/runner/work/ggplot2/ggplot2/check/ggplot2.Rcheck/00_pkg_src/ggplot2/R/save.r:176)
Warning: Warning: <anonymous>: ... may be used in an incorrect context: ‘list(...)’ (/home/runner/work/ggplot2/ggplot2/check/ggplot2.Rcheck/00_pkg_src/ggplot2/R/save.r:176)

Looking at the corresponding line before vctrs, I guess this was the intention.

dev <- function(...) do.call(device, modify_list(list(...), call_args))

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - good catch

@yutannihilation yutannihilation merged commit b0d3366 into tidyverse:main Jul 26, 2022
@yutannihilation yutannihilation deleted the fix/plot_dev-dot-dot-dot-warning branch July 26, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants