Default bar width calculated panel-wise #5125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this somehow be optional? Couldn't you imagine you'd want the same width on all panels despite varying data resolution? |
|
I don't think it would make a lot of sense to make this optional, but I'm willing to entertain other ideas. To be clear: this PR will not introduce variable widths per panel, the bars in all panels will still have the same width. It is just that the resolution to determine the global width is calculated per panel, so that cross-panel resolution will become irrelevant (as I think it should be). |
This was referenced Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #4336.
Briefly, instead of determining the global resolution for calculating the default width, it now considers panel-wise resolution.