Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #5145 #5146

Merged
merged 8 commits into from Jan 25, 2023
Merged

Closes #5145 #5146

merged 8 commits into from Jan 25, 2023

Conversation

dkahle
Copy link
Contributor

@dkahle dkahle commented Jan 11, 2023

No description provided.

teunbrand
teunbrand requested changes Jan 11, 2023
View reviewed changes
Copy link
Collaborator

@teunbrand teunbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preparing a PR!

I've left a suggestion that I think will simplify the issue even further.

R/geom-defaults.r Outdated Show resolved Hide resolved
@teunbrand
Copy link
Collaborator

teunbrand commented Jan 19, 2023 •
edited

Would you mind adding a small unit test to tests/testthat/test-geom-.R that tests for the behaviour you care about (class, ordering)? It is mostly so that we don't accidentally break that behaviour in the future.

@teunbrand teunbrand mentioned this pull request Jan 19, 2023
Closed
@dkahle
Copy link
Contributor Author

dkahle commented Jan 24, 2023

Sure, give that a look. I also added a few examples to the docs, but I know time is at a premium for the graphics part. If we need to take that out, no objection.

teunbrand
teunbrand reviewed Jan 24, 2023
View reviewed changes
R/geom-defaults.r Outdated Show resolved Hide resolved
teunbrand
teunbrand reviewed Jan 24, 2023
View reviewed changes
R/geom-defaults.r Outdated Show resolved Hide resolved
@teunbrand
Copy link
Collaborator

teunbrand commented Jan 24, 2023 •
edited

Thanks, the update looks great! I only have two minor comments. If you'd like, you can add a bullet to the NEWS.md file with these updates. After that I think this PR is good to go

teunbrand
teunbrand approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@teunbrand teunbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for contributing, looks great now!

@teunbrand teunbrand merged commit fda4dfa into tidyverse:main Jan 25, 2023
@dkahle
Copy link
Contributor Author

dkahle commented Jan 25, 2023

Thanks @teunbrand !

@dkahle dkahle deleted the class-default-aes branch January 25, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teunbrand teunbrand teunbrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dkahle @teunbrand